[webkit-reviews] review requested: [Bug 15135] REGRESSION (r19843-r19850): Changing a flexbox's contents makes its container scroll to the top : [Attachment 31283] Patch v2

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 15135: REGRESSION (r19843-r19850): Changing a flexbox's contents makes its
container scroll to the top
https://bugs.webkit.org/show_bug.cgi?id=15135

Attachment 31283: Patch v2
https://bugs.webkit.org/attachment.cgi?id=31283&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Thanks for the review!

I understood that we cannot add members into RenderBlock. As the delayed
repaint needs some contexts of layout (repainter, repaintBottom and
repaintTop), I created a hash map which holds the context information and is
used only when a flexbox is layouting its children. This hack looks not so
good, but it seems that this kind of technique is often used for flexible box
support (e.g., gOverrideSizeMap in RenderBox.cpp) and this won't consume extra
RAM for HTMLs which have no flexboxes.

Could you take a look again?

Thanks!