[webkit-reviews] review denied: [Bug 26278] Patch that make WebCore have a RenderTheme per page : [Attachment 31105] Fixed the patch to not include a wrong file

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>'s request for review:
Bug 26278: Patch that make WebCore have a RenderTheme per page
https://bugs.webkit.org/show_bug.cgi?id=26278

Attachment 31105: Fixed the patch to not include a wrong file
https://bugs.webkit.org/attachment.cgi?id=31105&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
One improveement would be to avoid making new RenderThemes on platforms that
don't need per-page themes...

(1) Make RenderTheme refcounted.
(2) Make Page's theme() call a function like 

PassRefPtr<RenderTheme> RenderTheme::themeForPage(Page*).

(3) On platforms that want to have per-page theme support, this function could
construct a new theme and hand it back.

On platforms that don't need per-page theme support, they could just hand back
the static singleton as before (which should have an initial ref() also or
maybe be held in static RefPtr).

I'm not sure every RenderTheme subclass has made its data members and such
static, so I'm concerned about moving away from singletons on platforms that
don't need per-page support... hence the suggestion of a way to keep the
singleton model.