[webkit-reviews] review requested: [Bug 25709] Skia/Cairo image decoders should be merged : [Attachment 31123] part five

[bugzilla-daemon at webkit.org]

Peter Kasting <pkasting at google.com> has asked  for review:
Bug 25709: Skia/Cairo image decoders should be merged
https://bugs.webkit.org/show_bug.cgi?id=25709

Attachment 31123: part five
https://bugs.webkit.org/attachment.cgi?id=31123&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
The main thing in this patch is a rewrite of Skia's
GIFImageDecoder::haveDecodedRow() to not use raw pointers to the data inside
the framebuffer, and instead do everything through coordinates.  This makes the
code a lot more readable too (IMO).

After this patch, none of the Skia image decoders has anything Skia-specific or
unimplementable by Cairo inside it.  I'll then need to write a similar patch
for the Cairo side adding the Cairo versions of the new ImageDecoder.h
functions, and then we can start actually merging the files together.