[webkit-reviews] review denied: [Bug 26253] Still update main resource meta-data if resource tracking is disabled : [Attachment 31044] Update main resource meta-data when resource tracking is off
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 8 06:22:57 PDT 2009
Timothy Hatcher <timothy at hatcher.name> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 26253: Still update main resource meta-data if resource tracking is
disabled
https://bugs.webkit.org/show_bug.cgi?id=26253
Attachment 31044: Update main resource meta-data when resource tracking is off
https://bugs.webkit.org/attachment.cgi?id=31044&action=review
------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Using PassRefPtr here isn't correct, since you are not transfering ownership.
The InspectorController still owns the resources. A plain pointer return is
best.
r+ if you change that.
More information about the webkit-reviews
mailing list