[webkit-reviews] review granted: [Bug 17375] [Gtk] Set user-agent from application : [Attachment 31040] Add webview property to get UA string + refactor UA version string in configure.ac

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 8 06:17:58 PDT 2009


Gustavo Noronha (kov) <gns at gnome.org> has granted Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 17375: [Gtk] Set user-agent from application
https://bugs.webkit.org/show_bug.cgi?id=17375

Attachment 31040: Add webview property to get UA string + refactor UA version
string in configure.ac
https://bugs.webkit.org/attachment.cgi?id=31040&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +	* Since: 1.1.8

This should be 1.1.9, when landing.

> +// Internal use only. See #WebKitWebView 'user-agent' property to get the
> +// User-Agent string used by the WebView

We will probably want to have getter and setter functions, since we have for
most things already, so I recommend making this public. For now, I think this
suffices, and since we already had a consensus on adding the property,
including the getter (which is the API addition), I'll just go ahead and r+.


More information about the webkit-reviews mailing list