[webkit-reviews] review requested: [Bug 16855] Multiple correctness issues with javascript URLs : [Attachment 30975] 12161.1.txt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 4 17:20:42 PDT 2009


Michael Nordman <michaeln at google.com> has asked  for review:
Bug 16855: Multiple correctness issues with javascript URLs
https://bugs.webkit.org/show_bug.cgi?id=16855

Attachment 30975: 12161.1.txt
https://bugs.webkit.org/attachment.cgi?id=30975&action=review

------- Additional Comments from Michael Nordman <michaeln at google.com>
Here's the patch mentioned in the previous comment.

The crash I'm seeing is because the Document (and relatives) is being deleted,
but resource loads are still pending. The 'fix' for that in here feels hacky.
Seems like stopAllLoaders() should have taken care of things?

The fix for he correctness issue feels more correct to me.

All existing layout test pass with this patched in. I'm looking into making
additional layout test for javascript urls of this form.


More information about the webkit-reviews mailing list