[webkit-reviews] review requested: [Bug 26148] Unfork RenderThemeChromium{Win, Linux}.{h, cc} : [Attachment 30974] Factors out a common RenderThemeChromiumSkia class and makes RenderThemeChromiumLinux and RenderThemeChromiumWin depend on it.

[bugzilla-daemon at webkit.org]

Albert J. Wong <ajwong at chromium.org> has asked	for review:
Bug 26148: Unfork RenderThemeChromium{Win,Linux}.{h,cc}
https://bugs.webkit.org/show_bug.cgi?id=26148

Attachment 30974: Factors out a common RenderThemeChromiumSkia class and makes
RenderThemeChromiumLinux and RenderThemeChromiumWin depend on it.
https://bugs.webkit.org/attachment.cgi?id=30974&action=review

------- Additional Comments from Albert J. Wong <ajwong at chromium.org>
The only bits left in RenderThemeChromiumLinux are the methods taht the windows
version does not override itself.

Here are the changes that were not just pure code shuffling:
  1) defaultFontSize was combined, and turned into a protected class member
  2) defaultGUIFont was combined, and turned into a protected class member. 
The windows code needed some extra type conversion code added to make this
work.
  3) caretBlinkInterval was split into caretBlinkInterval and
caretBlinkIntervalInternal to centralize the layout test special code path.

The rest should be just shuffling of code around.

Note that there is a bit of a wart in that some resources referred to by
RenderThemeChromiumSkia have names like themeWinUserAgentStyleSheet, or
linuxCheckboxOn.  I dont' think the naming is hurtful enough to bother cleaning
up at this point.