[webkit-reviews] review denied: [Bug 27436] gobject bindings need access to keyCode on KeyboardEvents! : [Attachment 33193] comments out only the 2nd initKeyboardEvent function on LANGUAGE_GOBJECT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 31 20:08:12 PDT 2009


Eric Seidel <eric at webkit.org> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27436: gobject bindings need access to keyCode on KeyboardEvents!
https://bugs.webkit.org/show_bug.cgi?id=27436

Attachment 33193: comments out only the 2nd initKeyboardEvent function on
LANGUAGE_GOBJECT
https://bugs.webkit.org/attachment.cgi?id=33193&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
ChangeLog name:
+2008-11-30  lkcl <lkcl at lkcl.net>

Tabs in ChangeLog.

I think Mark wanted a different solution for c bindings in general, but in this
change looks fine overall to me.

r- for the ChangeLog issues.


More information about the webkit-reviews mailing list