[webkit-reviews] review denied: [Bug 27430] adds glib / gobject bindings to webkit gtk port : [Attachment 33059] adds use of glib / gobject bindings to webkitwebframe

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27430: adds glib / gobject bindings to webkit gtk port
https://bugs.webkit.org/show_bug.cgi?id=27430

Attachment 33059: adds use of glib / gobject bindings to webkitwebframe
https://bugs.webkit.org/attachment.cgi?id=33059&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore avoids using superfluous argument names in headers:
 91	gpointer toGDOM(DOMWindow* doc);
 92	gpointer toGDOM(Document* doc);
 93	gpointer toGDOM(XMLHttpRequest* obj);

We don't commit commented out code:
 407	 //WebKitWebFramePrivate* priv = frame->priv;

Name:
 2536 2008-11-30  lkcl	<lkcl at lkcl.net>

Otherwise looks fine.  I mean, I'm not really a gtk expert.  There are style
violations, but I assume this stuff is more supposed to be more gtk style than
webkit style, not sure.

r- for the above nits.	If you were a committer I could just r+ it and let you
fix it as you landed.