[webkit-reviews] review denied: [Bug 27883] [v8] check if proxy is present before invoking a handler : [Attachment 33878] Initial version

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied anton muhin <antonm at chromium.org>'s
request for review:
Bug 27883: [v8] check if proxy is present before invoking a handler
https://bugs.webkit.org/show_bug.cgi?id=27883

Attachment 33878: Initial version
https://bugs.webkit.org/attachment.cgi?id=33878&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: third_party/WebKit/WebCore/ChangeLog
> +2009-07-31  Anton Muhin  <antonm at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +

Please add:

Bug Title
Bug Link

"prepare-ChangeLog --bug #" will do this for you.

> +	   Do not invoke handler functio if proxy is NULL (that would lead to
NPE anyway).

typo: functio

Change NULL to 0 (since WebKit doesn't use NULL).

NPE is not an abbreviation that I'm familiar with but I guess you mean
crash/access violation.  It would be good to write it in a longer form without
using an abbreviation.

Also, this ChangeLog explains what but not why.  Please add why.


Can there be a layout test for whatever problem was encountered?
  If so, please add one.
  If not, why not?