[webkit-reviews] review requested: [Bug 27883] [v8] check if proxy is present before invoking a handler : [Attachment 33878] Initial version

[bugzilla-daemon at webkit.org]

anton muhin <antonm at chromium.org> has asked  for review:
Bug 27883: [v8] check if proxy is present before invoking a handler
https://bugs.webkit.org/show_bug.cgi?id=27883

Attachment 33878: Initial version
https://bugs.webkit.org/attachment.cgi?id=33878&action=review

------- Additional Comments from anton muhin <antonm at chromium.org>
To be honest, I would guess the code expects always not NULL proxy here as
listeners are enabled. (but I think in that case it should be documented with
ASSERT).  So I am by no means insisting on this patch.

One thing that stroke me is presence of GoogleUpdateClient in the call stack
(see
http://crash/reportdetail?reportid=19d99906cbceb8a7&product=Chrome&version=3.0.
196.0&date=&signature=WebCore::V8Proxy::callFunction%28v8::Handle).  My
immediate reaction is something wasn't initialized properly.

And I'll be on vacation two next weeks.