[webkit-reviews] review denied: [Bug 27825] All DOM Storage layout tests need to call layoutTestController.notifyDone() so they can be run as UI tests in Chromium : [Attachment 33758] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 29 19:19:14 PDT 2009


Mark Rowe (bdash) <mrowe at apple.com> has denied Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27825: All DOM Storage layout tests need to call
layoutTestController.notifyDone() so they can be run as UI tests in Chromium
https://bugs.webkit.org/show_bug.cgi?id=27825

Attachment 33758: patch
https://bugs.webkit.org/attachment.cgi?id=33758&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
This change doesn't make any sense.  layoutTestController.notifyDone() is not
necessary unless a test first calls waitUntilDone().  You should fix your test
harness to match the expectations of the tests, not the other way around.


More information about the webkit-reviews mailing list