[webkit-reviews] review denied: [Bug 27779] WINCE PORT: modified graphics files : [Attachment 33731] add some comments for removed ASSERT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 29 20:49:45 PDT 2009


George Staikos <staikos at kde.org> has denied  review:
Bug 27779: WINCE PORT: modified graphics files
https://bugs.webkit.org/show_bug.cgi?id=27779

Attachment 33731: add some comments for removed ASSERT
https://bugs.webkit.org/attachment.cgi?id=33731&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
	
> +#if !PLATFORM(WINCE) || PLATFORM(QT)
>	   PlatformGraphicsContext* platformContext() const;
> +#endif
> +
> +	   const Font& font() const;
> +	   void setFont(const Font&);

  I think we have a problem here.  Why are these unconditionally added?

  In retrospect I think we need more cleanup.


More information about the webkit-reviews mailing list