[webkit-reviews] review granted: [Bug 27549] Make run-webkit-lint supports files as arguments : [Attachment 33712] Updates and improved patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>'s request for review:
Bug 27549: Make run-webkit-lint supports files as arguments
https://bugs.webkit.org/show_bug.cgi?id=27549

Attachment 33712: Updates and improved patch
https://bugs.webkit.org/attachment.cgi?id=33712&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I'm willing to do these changes, but I'd like to know how you feel about the
"consider" comments.


> diff --git a/WebKitTools/Scripts/check-webkit-style
b/WebKitTools/Scripts/check-webkit-style
> +  The file parameter is optional and multiple file scan be passed in.
Leaving

Consider:
  The file parameter is optional and multiple files to scan may be passed in

> +  out the file parameter will apply the check to the files currently not

Consider:
  out the file parameter will apply the check to the files changed 
  according to the scm system.


> +    if files and "--git-commit" in flags:
> +	   sys.stderr.write("ERROR: It is not possible to check files "
> +			     "and a specific commit at the same time.\n" +
cpp_style._USAGE)
>	   sys.exit(1)
> +    elif files:

Make this an "if" since the pre if "exits".