[webkit-reviews] review denied: [Bug 27651] [Qt] QWebPluginDatabase API : [Attachment 33438] Allow to explicitly choose a preferred plugin for a mimetype.

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Jakub Wieczorek
<faw217 at gmail.com>'s request for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33438: Allow to explicitly choose a preferred plugin for a mimetype.
https://bugs.webkit.org/attachment.cgi?id=33438&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
The patch looks good, but I think there's one bug left: The m_preferredPlugins
hash keeps PluginPackage instances alife, through the use of RefPtr. When
calling clear() as well as refresh() we may have to free the references to
these plugins, to allow the pluginpackage objects to be freed.