[webkit-reviews] review denied: [Bug 27434] adding necessary functions and properties to Document IDL gobject bindings : [Attachment 33324] adds read-only access to Document.location pending writing of custom code to set location properties (at some indeterminate future point)

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27434: adding necessary functions and properties to Document IDL gobject
bindings
https://bugs.webkit.org/show_bug.cgi?id=27434

Attachment 33324: adds read-only access to Document.location pending writing of
custom code to set location properties (at some indeterminate future point)
https://bugs.webkit.org/attachment.cgi?id=33324&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
As far as I can see this doesn't really address the issue, which relates to a
member of type Location being exposed.	Document::location being read-only does
not prevent you from mutating Location::href, which will fail unless your
bindings explicitly handle setters for Location's members in a custom fashion
(WebCore::Location has no setHref method).  Given that the URL of a document is
trivially retrievable from the ports WebView object, I don't see any reason to
#if this particular member until the problem here can be addressed in a more
robust manner.