[webkit-reviews] review denied: [Bug 27437] make HTMLAppletElement and HTMLEmbedElement compliant with de-facto JS-based standards under gobject bindings : [Attachment 33328] corrects grammar, complies with precommit hook, adds correct date and name
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 23 09:58:57 PDT 2009
Mark Rowe (bdash) <mrowe at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27437: make HTMLAppletElement and HTMLEmbedElement compliant with de-facto
JS-based standards under gobject bindings
https://bugs.webkit.org/show_bug.cgi?id=27437
Attachment 33328: corrects grammar, complies with precommit hook, adds correct
date and name
https://bugs.webkit.org/attachment.cgi?id=33328&action=review
------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 44473)
> +++ WebCore/ChangeLog (working copy)
> @@ -62327,6 +62347,17 @@
> (WebCore::PluginPackage::fetchInfo):
> (WebCore::PluginPackage::isPluginBlacklisted):
>
> +2008-11-30 Luke Kenneth Casson Leighton <lkcl at lkcl.net>
> +
> + Reviewed by NOBODY (OOPS!)
> +
> + https://bugs.webkit.org/show_bug.cgi?id=27437
> +
> + Make width and height attributes DOMString except for
LANGUAGE_OBJECTIVE_C due to API backwards-compatibility reasons. HTML5
specification has HTMLAppletElement and HTMLEmbedElement width and height now
marked as a DOMString.
> +
> + * html/HTMLAppletElement.idl: width and height attributes made to be
DOMString except for LANGUAGE_OBJECTIVE_C where they are kept as long
> + * html/HTMLEmbedElement.idl: width and height attributes made to be
DOMString except for LANGUAGE_OBJECTIVE_C where they are kept as long
> +
It's no longer November 2008 and there are still tabs in your ChangeLog entry…
Can you please fix this minor issue so that this can be landed?
More information about the webkit-reviews
mailing list