[webkit-reviews] review denied: [Bug 27523] Don't convert soft hyphens in selections into spaces : [Attachment 33234] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Adam Langley
<agl at chromium.org>'s request for review:
Bug 27523: Don't convert soft hyphens in selections into spaces
https://bugs.webkit.org/show_bug.cgi?id=27523

Attachment 33234: patch
https://bugs.webkit.org/attachment.cgi?id=33234&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This looks like a duplicate of bug 11154 and/or 26774 to me. Please search for
existing Bugzilla bugs when submitting new ones.

We usually check whether the test is running under DRT to avoid console spew if
it's not. Also, it's slightly better to call dumpAsText as early as possible,
to ease investigation in case something in the test suddenly starts raising
exceptions.

if (window.layoutTestController)
    layoutTestController.dumpAsText();

The ChangeLog doesn't explain changes to charset-xuser-defined-expected.txt.
Why are these safe?

r- for the reasons given by Peter Arrenbrecht above.