[webkit-reviews] review denied: [Bug 27474] Crash if the selection is set in a textarea/text input immediately after setting display:none : [Attachment 33129] Fixes crashes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 22 09:37:09 PDT 2009


Darin Adler <darin at apple.com> has denied Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 27474: Crash if the selection is set in a textarea/text input immediately
after setting display:none
https://bugs.webkit.org/show_bug.cgi?id=27474

Attachment 33129: Fixes crashes
https://bugs.webkit.org/attachment.cgi?id=33129&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This is definitely the right basic approach. And what's here is OK if it's OK
for these functions to do nothing when there are pending stylesheets.

But I think it's likely that for website compatibility, these functions need to
work even when called early during loading before all the stylesheets are
loaded. The code needs to call updateLayoutIgnorePendingStylesheets instead of
updateLayout for cases where that needs to work.

I'm going to say review- because of that issue, but I could be convinced to
reconsider if you think I'm wrong.


More information about the webkit-reviews mailing list