[webkit-reviews] review denied: [Bug 27528] run-webkit-lint should have --git-commit option : [Attachment 33241] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 21 23:36:00 PDT 2009


David Levin <levin at chromium.org> has denied Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27528: run-webkit-lint should have --git-commit option
https://bugs.webkit.org/show_bug.cgi?id=27528

Attachment 33241: Patch v2
https://bugs.webkit.org/attachment.cgi?id=33241&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/WebKitTools/Scripts/run-webkit-lint
b/WebKitTools/Scripts/run-webkit-lint
> @@ -57,6 +57,13 @@ Syntax: %(program_name)s [--verbose=#] [--output=vs7]
[--filter=-x,+y,...]

Shouldn't the "Syntax" line get [--git-commit=<COMMITISH>] added to it?


More information about the webkit-reviews mailing list