[webkit-reviews] review granted: [Bug 27529] run-webkit-lint checks code which are not changed : [Attachment 33242] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 21 23:24:30 PDT 2009


David Levin <levin at chromium.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27529: run-webkit-lint checks code which are not changed
https://bugs.webkit.org/show_bug.cgi?id=27529

Attachment 33242: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33242&action=review

------- Additional Comments from David Levin <levin at chromium.org>

>		   if not line_numbers:
>		       for line in diff.lines:
> -			   line_numbers.add(line[1])
> +			   # When deleted line is not set, it means that
> +			   # the line is newly added.

There is no need to wrap this comment.

> +			   if not line[0]:
> +			       line_numbers.add(line[1])
Of course...nice fix.


More information about the webkit-reviews mailing list