[webkit-reviews] review canceled: [Bug 27461] Add checks for namespace indentation to cpplint : [Attachment 33178] Add checks for namespace indentation to cpplint (try 4)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 21 09:25:12 PDT 2009


Jakob Petsovits <jpetso at gmx.at> has canceled Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27461: Add checks for namespace indentation to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27461

Attachment 33178: Add checks for namespace indentation to cpplint (try 4)
https://bugs.webkit.org/attachment.cgi?id=33178&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Adapt checks for goto labels as discussed with Dave on IRC: empirical research
shows that such labels are not used in header files, and therefore don't need
to be checked. Also, add a test case for goto labels in implementation files,
just to make sure the check actually works (although it probably won't be
triggered anytime soon, because indented namespaced hardly exist anywhere in
implementation files).


More information about the webkit-reviews mailing list