[webkit-reviews] review granted: [Bug 27502] Web Inspector: Add ability to evaluate selection while on break point. : [Attachment 33177] patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 27502: Web Inspector: Add ability to evaluate selection while on break
point.
https://bugs.webkit.org/show_bug.cgi?id=27502

Attachment 33177: patch
https://bugs.webkit.org/attachment.cgi?id=33177&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +	   var shortcut = WebInspector.KeyboardShortcut.makeKey(
> +	       69 /* 'E' */,
> +	       platformSpecificModifier |
WebInspector.KeyboardShortcut.Modifiers.Shift);

I think that would be fine and more readable on one line.

Talk to Sam Weinig, he has a patch (maybe landed) that will let us add
"evaluate on hover".