[webkit-reviews] review canceled: [Bug 27291] Support lint for patches : [Attachment 33148] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 20 23:57:14 PDT 2009
Shinichiro Hamaji <hamaji at chromium.org> has canceled Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27291: Support lint for patches
https://bugs.webkit.org/show_bug.cgi?id=27291
Attachment 33148: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33148&action=review
------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
> Patch v1
Actually, this is v2 :(
Hmm... the usage of current patch is
% run-webkit-lint [options] [commitish]...
with this syntax, we cannot add support of linting files. Maybe the following
syntax would be better?
% run-webkit-lint [--git-commit=<commitish>] [options] [file]...
For now, to keep the patch small, I'll re-upload a patch with removing support
of linting specified commit.
More information about the webkit-reviews
mailing list