[webkit-reviews] review granted: [Bug 27483] diff_parser should accept lines without trailing \n : [Attachment 33145] Patch v1

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27483: diff_parser should accept lines without trailing \n
https://bugs.webkit.org/show_bug.cgi?id=27483

Attachment 33145: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33145&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog

> +
> +	   Normalize the input lines by removing a trailing newline.
> +	   Also, add a case for unittest for newly added files.
I think this reads better: "Also, add a case to the unittest for newly added
files."

fwiw, it is best to keep your patches focused on one thing and this does a bit
more, so the bug doesn't reflect what is being done. However, it is all rather
simple and you do describe it, so no need to break it up this time.