[webkit-reviews] review denied: [Bug 26948] Need to refactor Worker to derive from AbstractWorker : [Attachment 32892] proposed patch (fixed problem with previous patch that prevent V8 bindings from compiling)

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 26948: Need to refactor Worker to derive from AbstractWorker
https://bugs.webkit.org/show_bug.cgi?id=26948

Attachment 32892: proposed patch (fixed problem with previous patch that
prevent V8 bindings from compiling)
https://bugs.webkit.org/attachment.cgi?id=32892&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few thing to address (one nit and one bug).

> diff --git a/WebCore/bindings/js/JSWorkerCustom.cpp
b/WebCore/bindings/js/JSWorkerCustom.cpp
> @@ -42,40 +40,7 @@ void JSWorker::mark()
>  {
>      DOMObject::mark();

I think this should be JSAbstractWorker::mark(); or even better just
"Base::mark();" (and then this would have not have needed to change).



> diff --git a/WebCore/bindings/v8/custom/V8WorkerCustom.cpp
b/WebCore/bindings/v8/custom/V8WorkerCustom.cpp
> -    if (args.Length() == 0) {
> +    if (args.Length() == 0)
If you're going to fix the style here

       if (!args.Length())

is what you want.