[webkit-reviews] review requested: [Bug 27323] Better support for non-Cygwin SVN on Windows : [Attachment 32904] Fixes, part 3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 16 17:15:20 PDT 2009
Peter Kasting <pkasting at google.com> has asked Steve Falkenburg
<sfalken at apple.com> for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323
Attachment 32904: Fixes, part 3
https://bugs.webkit.org/attachment.cgi?id=32904&action=review
------- Additional Comments from Peter Kasting <pkasting at google.com>
While this patch looks large, it's just a search-and-replace of:
set PATH=%SystemDrive%\cygwin\bin;%PATH%
...with:
%SystemDrive%\cygwin\bin\which.exe bash
if errorlevel 1 set
PATH=%SystemDrive%\cygwin\bin;%PATH%
There is one place I didn't touch:
JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore.make. I wasn't sure what
the right syntax in here was (I don't know makefiles) or even what this
makefile was used for. Feel free to give direction.
More information about the webkit-reviews
mailing list