[webkit-reviews] review granted: [Bug 27321] v8 bindings missing from the build : [Attachment 32885] proposed patch that fixes the windows build when ENABLE_SHARED_WORKERS=true

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 16 13:17:26 PDT 2009


David Levin <levin at chromium.org> has granted Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 27321: v8 bindings missing from the build
https://bugs.webkit.org/show_bug.cgi?id=27321

Attachment 32885: proposed patch that fixes the windows build when
ENABLE_SHARED_WORKERS=true
https://bugs.webkit.org/attachment.cgi?id=32885&action=review

------- Additional Comments from David Levin <levin at chromium.org>
The new modes being set on:
 WebCore/bindings/v8/custom/V8AbstractWorkerCustom.cpp
 WebCore/bindings/v8/custom/V8SharedWorkerCustom.cpp

Seem odd (to both of us).  I'll remove them from the patch when I land it.


More information about the webkit-reviews mailing list