[webkit-reviews] review granted: [Bug 27337] Add a getter in MessagePortChannel for the PlatformMessagePortChannel : [Attachment 32886] new patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 16 13:08:31 PDT 2009


David Levin <levin at chromium.org> has granted John Abd-El-Malek
<jam at chromium.org>'s request for review:
Bug 27337: Add a getter in MessagePortChannel for the
PlatformMessagePortChannel
https://bugs.webkit.org/show_bug.cgi?id=27337

Attachment 32886: new patch
https://bugs.webkit.org/attachment.cgi?id=32886&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I missed your earlier comment too.

> ah, I still get confused sometimes with all the RefPtr objects.  Thanks, I
only
> need a pointer.  I wasn't sure if it's ok to pass around raw pointers of ref
> counted objects.

Actually, I wasn't aware of this guideline until recently, but it is stated
well here: http://webkit.org/coding/RefPtr.html

"If a function’s result is an object, but ownership is not being transferred,
the result should be a raw pointer. This includes most getter functions."


More information about the webkit-reviews mailing list