[webkit-reviews] review denied: [Bug 26988] Haiku-specific files for WebCore : [Attachment 32307] Patch to add a fifth bunch of Haiku-specific files for WebCore.

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32307: Patch to add a fifth bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32307&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>

> +// This might be useful, but it not used for now
> +/*
> +static BView* haikuWidgetForPage(const Page* page)
> +{
> +    Frame* frame = (page ? page->mainFrame() : 0);
> +    FrameView* frameView = (frame ? frame->view() : 0);
> +
> +    if (!frameView)
> +	   return 0;
> +
> +    return frameView->haikuWidget();
> +}*/

We don't include commented out code in the tree


> +int screenDepth(Widget*)
> +{
> +    BScreen screen;
> +    // FIXME: We assume this screen is valid
> +    color_space cs = screen.ColorSpace();
> +
> +    size_t pixelChunk, rowAlignment, pixelsPerChunk;
> +    if (get_pixel_size_for(cs, &pixelChunk, &rowAlignment, &pixelsPerChunk)
== B_OK) {
> +	   // FIXME: Not sure if this is right
> +	   return pixelChunk * 8;
> +    }
Single line block shouldn't have braces

> +void SharedTimerHaiku::setFireTime(double fireTime)
> +{
> +    m_fireTime = fireTime;
> +    if (m_fireTime > 0 && m_shouldRun) {
> +	   bigtime_t sleepyTime = (bigtime_t)((m_fireTime - WTF::currentTime())
* 1000000);
You should be using a c++ style cast

> +	   
> +	   if(sleepyTime < 0)
space between if and (

> +// WebCore functions
> +void setSharedTimerFiredFunction(void (*function)())
> +{
> +    SharedTimerHaiku* timer=getSharedTimerHaiku();
Need spaces around =

> +namespace WebCore {
> +    class SharedTimerHaiku : public BMessageFilter {
> +	   public:
> +	       SharedTimerHaiku();
> +	       ~SharedTimerHaiku();
> +
> +	       void setFireTime(double fireTime);
> +	       void setFireFunction(void (*function)());
> +	       void setShouldRun(bool shouldRun);
> +
> +	       //void  MessageReceived(BMessage* message);
> +	       virtual filter_result Filter(BMessage* message, BHandler**
_target);
> +
> +	   private:
> +	       //void wait();
> +	       //static int32 threadFunction(void *data);
> +
> +	       //thread_id m_thread;
> +	       //sem_id m_waitSem;
Don't included commented out members, you should file a bug on resurrecting
these