[webkit-reviews] review denied: [Bug 26988] Haiku-specific files for WebCore : [Attachment 32304] Patch to add ScrollBar and ScrollView code specific to Haiku.

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32304: Patch to add ScrollBar and ScrollView code specific to Haiku.
https://bugs.webkit.org/attachment.cgi?id=32304&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
> +
> +void ScrollViewCanvasHaiku::Draw(BRect updateRect)
> +{
> +    FrameView* fv = static_cast<FrameView*>(m_scrollView);
> +    if (!fv || !fv->frame() || !fv->frame()->contentRenderer())
> +	   return;
> +
> +    while (fv->needsLayout()) {
> +	   fv->layout();
> +    }
Single line code block should not have braces :D

> +void ScrollViewCanvasHaiku::KeyDown(const char* bytes, int32 numBytes)
> +{
> +    BMessage* message = Looper()->CurrentMessage();
> +    if (!message)
> +	   return;
> +
> +    WebCore::FrameView* fv = static_cast<WebCore::FrameView*>(m_scrollView);

> +    if (!fv || !fv->frame())
> +	return;
> +
> +   
if(!fv->frame()->eventHandler()->keyEvent(PlatformKeyboardEvent(message)))
> +	printf("-->KeyDown: not arrived\n");	
> +
> +    if((int)bytes[0] != (int)B_TAB)
> +	   BView::KeyDown(bytes, numBytes);

We use c++ casts for all casts in webkit -- eg. static_cast

> +}
> +
> +void ScrollViewCanvasHaiku::KeyUp(const char* bytes, int32 numBytes)
> +{
> +    BMessage* message = Looper()->CurrentMessage();
> +    if (!message)
> +	   return;
> +
> +    WebCore::FrameView* fv = static_cast<WebCore::FrameView*>(m_scrollView);

> +    if (!fv || !fv->frame())
> +	return;
> +
> +   
if(fv->frame()->eventHandler()->keyEvent(PlatformKeyboardEvent(message)))
> +	printf("-->KeyUp: not arrived\n"); 
> +
> +    if(bytes[0] != (int)B_TAB)
ditto

Basically looks fine except the aforementioned style issues