[webkit-reviews] review denied: [Bug 26988] Haiku-specific files for WebCore : [Attachment 32303] Patch to add a fourth bunch of Haiku-specific files for WebCore.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 16 00:36:51 PDT 2009
Oliver Hunt <oliver at apple.com> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988
Attachment 32303: Patch to add a fourth bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32303&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
> +void Pasteboard::writeSelection(Range* selectedRange, bool
canSmartCopyOrDelete, Frame* frame)
> +{
> + BMessage* data;
> +
> + if (be_clipboard->Lock()) {
> + be_clipboard->Clear();
> + if ((data = be_clipboard->Data())) {
> + data->AddString("text/plain", BString(frame->selectedText()));
> + be_clipboard->Commit();
> + }
> + be_clipboard->Unlock();
> + }
> +}
You'll want a bug to track supporting pasting of rich text. Also i'm concerned
about where be_clipboard comes from? If it's the global pasteboard in haiku
you don't want to use it here
> +String Pasteboard::plainText(Frame* frame)
> +{
> + BString string;
> + BMessage* data;
> +
> + if (be_clipboard->Lock()) {
> + if ((data = be_clipboard->Data())) {
> + data->FindString("text/plain", &string);
> + }
No braces on a single line if statement
More information about the webkit-reviews
mailing list