[webkit-reviews] review denied: [Bug 27318] Allow LocalStorage to be enabled without enabling SessionStorage : [Attachment 32815] v1

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27318: Allow LocalStorage to be enabled without enabling SessionStorage
https://bugs.webkit.org/show_bug.cgi?id=27318

Attachment 32815: v1
https://bugs.webkit.org/attachment.cgi?id=32815&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/page/DOMWindow.cpp
> ===================================================================
> --- WebCore/page/DOMWindow.cpp	(revision 45916)
> +++ WebCore/page/DOMWindow.cpp	(working copy)
> @@ -552,6 +552,9 @@ Storage* DOMWindow::sessionStorage() con
>	   return 0;
>  
>      Document* document = m_frame->document();
> +    Settings* settings = document->settings();
> +    if (!settings || !settings->sessionStorageEnabled())

You should just use page->settings() here which cannot be null.

Otherwise, looks good to me.