[webkit-reviews] review granted: [Bug 27241] bugzilla-tool post-commits silently fails with bad args : [Attachment 32833] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 15 21:59:29 PDT 2009
Eric Seidel <eric at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27241: bugzilla-tool post-commits silently fails with bad args
https://bugs.webkit.org/show_bug.cgi?id=27241
Attachment 32833: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32833&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
You could probably re-use the self.argnames string (or wahtever it's called).
Instead of re-typing "COMMITTISH".
I probably woudl have written "'%s' is not a COMMITISH" as "unable to parse
commit is from %s".
What you have is fine. Or with one or more of the modifications suggested
above.
Thanks!
More information about the webkit-reviews
mailing list