[webkit-reviews] review requested: [Bug 27322] Inspector: Create New DOM Storage Items via DataGrid : [Attachment 32821] Make DOM Storage DataGrid More Interactive

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 15 17:29:04 PDT 2009


Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27322: Inspector: Create New DOM Storage Items via DataGrid
https://bugs.webkit.org/show_bug.cgi?id=27322

Attachment 32821: Make DOM Storage DataGrid More Interactive
https://bugs.webkit.org/attachment.cgi?id=32821&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
- Added a "CreationDataGridNode" type that can delete its special data and
transform back into a normal DataGridNode.
- Added a reference in the DataGrid to a CreationDataNode if one exists: @see
addCreationNode()
- Clicking anywhere in the excess space will select the bottom row (an existing
blank row)
- DOM Storage specific logic forces it to select the leftmost td (to set a Key)


I see a potential problem with sorting the GridData table.  However, sorting
wasn't working for me to begin with (was it ever working).  However, the
special CreationDataNode, if it exists, has this.isCreationNode and thus can
easily be sorted last.


More information about the webkit-reviews mailing list