[webkit-reviews] review denied: [Bug 20348] Background color formatting lost on enter : [Attachment 32820] fixes the bug and renames copyInheritableProperties to copyPropertiesForEditing and removes removeComputedInheritablePropertiesFrom

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Ryosuke Niwa
<ryosuke.niwa at gmail.com>'s request for review:
Bug 20348: Background color formatting lost on enter
https://bugs.webkit.org/show_bug.cgi?id=20348

Attachment 32820: fixes the bug and renames copyInheritableProperties to
copyPropertiesForEditing and removes removeComputedInheritablePropertiesFrom
https://bugs.webkit.org/attachment.cgi?id=32820&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This name is not sufficiently clear:
+static const int propertiesForEditing[] = {

What are these actually used for?

Do we have tests for both of these?
     // Properties for editing
 1472	  CSSPropertyTextDecoration,
 1473	  CSSPropertyBackgroundColor,
14701474 };

It seems this could break the optimization in:
handleStyleSpansBeforeInsertion
(which may already be broken)

Seems uses of this function are inconsistent in their needs.  I think this is
just a bad function which dates from before time:
(I stopped digging after http://trac.webkit.org/changeset/7314)

I think we should just deprecate this function and make a new (somewhat copied)
one which works for your uses.	All the callers of this need to change, but I'm
not gonna ask you to do that.