[webkit-reviews] review denied: [Bug 26915] HTML5: DOM binding of <datalist> element : [Attachment 32645] Proposed patch (rev.3)

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 26915: HTML5: DOM binding of <datalist> element
https://bugs.webkit.org/show_bug.cgi?id=26915

Attachment 32645: Proposed patch (rev.3)
https://bugs.webkit.org/attachment.cgi?id=32645&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Your ChangeLog is doubled.

Why is this right?
bool HTMLDataListElement::checkDTD(const Node* newChild)
 48 {
 49	return newChild->hasTagName(HTMLNames::optionTag) ||
HTMLElement::checkDTD(newChild);
 50 }

You should add a test to test the checkDTD code.  If you're trying to prevent
adding non-option elements then we need to test that?

Otherwise this looks fine.  r- since you're not a committer and this needs a
small update (and ideally another test).