[webkit-reviews] review granted: [Bug 27037] Fix baselines for inline tables. : [Attachment 32388] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 15 16:10:57 PDT 2009


Eric Seidel <eric at webkit.org> has granted Adam Langley <agl at chromium.org>'s
request for review:
Bug 27037: Fix baselines for inline tables.
https://bugs.webkit.org/show_bug.cgi?id=27037

Attachment 32388: patch
https://bugs.webkit.org/attachment.cgi?id=32388&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Haven't heard much from the table folks.  But this looks sane to me.

Please fix your style error:
+int RenderTable::baselinePosition(bool firstLine, bool isRootLineBox) const {
+    if (firstBody() && style()->display() == INLINE_TABLE)

Make sure you've run the layout tests when landing.


More information about the webkit-reviews mailing list