[webkit-reviews] review denied: [Bug 27145] [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html fails after r45615 : [Attachment 32651] patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 27145: [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html
fails after r45615
https://bugs.webkit.org/show_bug.cgi?id=27145

Attachment 32651: patch
https://bugs.webkit.org/attachment.cgi?id=32651&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +    const gchar* uri = webkit_web_history_item_get_uri(item);
> +    if (g_strcmp0(g_uri_parse_scheme(uri), "file") == 0) {

You are leaking the return of g_uri_parse_scheme here.

> +	   static gchar* layoutTestString = g_strdup("/LayoutTests/");
> +	   static gchar* fileTestString = g_strdup("(file test):");

These are also leaked. There should be no need to g_strdup here. Just use the
static strings instead?

> +	   result = g_string_append(result, pos + strlen(layoutTestString));

I'd suggest using sizeof("/LayoutTests/") instead of strlen.