[webkit-reviews] review granted: [Bug 18363] [GTK] Combo boxes cannot be opened pressing space : [Attachment 32652] addressed eric's feedback and added a manual test

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 18363: [GTK] Combo boxes cannot be opened pressing space
https://bugs.webkit.org/show_bug.cgi?id=18363

Attachment 32652: addressed eric's feedback and added a manual test
https://bugs.webkit.org/attachment.cgi?id=32652&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Looks good to me, after the changes. While you're at it, you could also have
enter also open the combo box, to match what GTK+ does. Should be a matter of
adding || keyCode == 'r' to the if inside SPACE_POP_MENU. Make it
SPACE_AND_RETURN_POP_MENU =P.