[webkit-reviews] review canceled: [Bug 27082] bugzilla-tool: Add --no-close switch to land-patches : [Attachment 32495] Patch v2

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has canceled David Kilzer
(ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 27082: bugzilla-tool: Add --no-close switch to land-patches
https://bugs.webkit.org/show_bug.cgi?id=27082

Attachment 32495: Patch v2
https://bugs.webkit.org/attachment.cgi?id=32495&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
(In reply to comment #9)
> (From update of attachment 32495 [details])
> So I'm confused by why we obsolete patches one at a time when landing them
when
> there is more than one to land. But we don't obsolete them when landing with
> the --no-close option.
> 
> I guess I would prefer we always obsoleted the patch after landing.  But I
> think you and I have different personal preferences here. :)
> 
> Either way, we should make them consistent, no?

My view of the world:

Obsolete patch:  A patch that has never and will never land.
Patch with cleared review flag:  A patch that has landed on a bug with more
than one patch up for review (which must necessarily stay open until all
patches have landed).

What's your view?

I'll make the change to be consistent in behavior and post another patch. 
Thanks!