[webkit-reviews] review denied: [Bug 18363] [GTK] Combo boxes cannot be opened pressing space : [Attachment 32586] Take away space out of ARROW_KEYS_POP_MENU and into SPACE_POP_MENU for platforms that display the popup when spacebar is pressed
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 10 23:08:01 PDT 2009
Eric Seidel <eric at webkit.org> has denied Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 18363: [GTK] Combo boxes cannot be opened pressing space
https://bugs.webkit.org/show_bug.cgi?id=18363
Attachment 32586: Take away space out of ARROW_KEYS_POP_MENU and into
SPACE_POP_MENU for platforms that display the popup when spacebar is pressed
https://bugs.webkit.org/attachment.cgi?id=32586&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
This looks like it will break mac. You seem to want #if and #endif then
another #if, not #elif
This also needs a manual test.
More information about the webkit-reviews
mailing list