[webkit-reviews] review requested: [Bug 27117] bugzilla-tool: use Mac OS X keychain for authentication : [Attachment 32517] Patch v1

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27117: bugzilla-tool: use Mac OS X keychain for authentication
https://bugs.webkit.org/show_bug.cgi?id=27117

Attachment 32517: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32517&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>

Reviewed by NOBODY (OOPS!).

Try reading credentials from git config first, then keychain if
running on Mac OS X, else prompt at the command-line.

* Scripts/modules/bugzilla.py: Added "import platform".
(credentials_from_git): Added.
(credentials_from_keychain): Added.
(is_mac_os_x): Added.
(read_credentials): Added.
(Bugzilla.__init__): Moved instance attribute bug_server to a
static attribute named bug-server_url.
(Bugzilla.bug_server_host): Added.  Extracted host name from
bug_server_url.
(Bugzilla.bug_server_regex): Updated to be created using
bug_server_host.
(Bugzilla.bug_server_url): Renamed from bug_server.
(Bugzilla.bug_url_for_bug_id): Updated for renaming of
bug_server to bug_server_url.
(Bugzilla.attachment_url_for_id): Ditto.
(Bugzilla.fetch_bug_ids_from_commit_queue): Ditto.
(Bugzilla.authenticate): Ditto.  Updated to use
read_credentials().
(Bugzilla.add_patch_to_bug): Ditto.
---
 2 files changed, 88 insertions(+), 19 deletions(-)