[webkit-reviews] review denied: [Bug 12195] XMLHttpRequest should raise SYNTAX_ERR when a parameter doesn't match HTTP syntax : [Attachment 32511] Fix for open()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 9 07:03:13 PDT 2009


Alexey Proskuryakov <ap at webkit.org> has denied Yuzo Fujishima
<yuzo at google.com>'s request for review:
Bug 12195: XMLHttpRequest should raise SYNTAX_ERR when a parameter doesn't
match HTTP syntax
https://bugs.webkit.org/show_bug.cgi?id=12195

Attachment 32511: Fix for open()
https://bugs.webkit.org/attachment.cgi?id=32511&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This patch doesn't fix anything that was mentioned in the bug description -
please open a new bug to discuss your proposed change. Besides, I don't see
where the spec requires open() to raise an exception if the URL is invalid -
see <http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#the-open-method>.

fast/js is not a good place for the test - this directory is for JavaScriptCore
tests. Please use fast/xmlhttprequest or http/tests/xmlhttprequest.


More information about the webkit-reviews mailing list