[webkit-reviews] review requested: [Bug 27109] Some tests in the Qt DRT pass and fail randomly, depending on whether previous tests used @font-face : [Attachment 32507] WebKitTools:

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has asked	for review:
Bug 27109: Some tests in the Qt DRT pass and fail randomly, depending on
whether previous tests used @font-face
https://bugs.webkit.org/show_bug.cgi?id=27109

Attachment 32507: WebKitTools:
https://bugs.webkit.org/attachment.cgi?id=32507&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>

2009-07-08  Simon Hausmann  <hausmann at webkit.org>

	Reviewed by NOBODY (OOPS!).

	https://bugs.webkit.org/show_bug.cgi?id=27109

	Fix side-effects in the Qt DRT with tests using application fonts.

	Detect if a test used application fonts and re-initialize the
fontconfig
	application fontset accordingly.

	* DumpRenderTree/qt/DumpRenderTree.cpp:
	(WebCore::DumpRenderTree::open): call initializeFonts and remove all
application fonts
	after running a testcase.
	(WebCore::DumpRenderTree::initializeFonts): Moved fontconfig
initialization code
	here from main.
	* DumpRenderTree/qt/DumpRenderTree.h: Declare initializeFonts.
	* DumpRenderTree/qt/main.cpp:
	(main): Moved fontconfig initialization code to DRT::initializeFonts.

LayoutTests:

2009-07-08  Simon Hausmann  <hausmann at webkit.org>

	Reviewed by NOBODY (OOPS!).

	https://bugs.webkit.org/show_bug.cgi?id=27109

	Remove various tests from the Qt skip list that previously failed
	due to DRT side-effects.

	* platform/qt/Skipped:
---
 6 files changed, 85 insertions(+), 34 deletions(-)