[webkit-reviews] review requested: [Bug 27108] Crash with fast/loader/frame-creation-removal.html : [Attachment 32506] WebKit/qt:

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 9 00:54:30 PDT 2009


Simon Hausmann <hausmann at webkit.org> has asked	for review:
Bug 27108: Crash with fast/loader/frame-creation-removal.html
https://bugs.webkit.org/show_bug.cgi?id=27108

Attachment 32506: WebKit/qt:
https://bugs.webkit.org/attachment.cgi?id=32506&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>

2009-07-08  Simon Hausmann  <hausmann at webkit.org>

	Reviewed by NOBODY (OOPS!).

	https://bugs.webkit.org/show_bug.cgi?id=27108

	Fix crash when in frame tree of a new frame before the new frame
	has been installed in the frame tree, similar to r35088.

	After calling Frame::init() the frame it may have been removed from the
	frame tree again through JavaScript. Detect this by checking the page()
	afterwards.

	* WebCoreSupport/FrameLoaderClientQt.cpp:
	(WebCore::FrameLoaderClientQt::createFrame):

LayoutTests:

2009-07-08  Simon Hausmann  <hausmann at webkit.org>

	Reviewed by NOBODY (OOPS!).

	https://bugs.webkit.org/show_bug.cgi?id=27108

	Remove fast/loader/frame-creation-removal.html from the skip list, it
	passes now.

	* platform/qt/Skipped:
---
 4 files changed, 33 insertions(+), 1 deletions(-)


More information about the webkit-reviews mailing list