[webkit-reviews] review denied: [Bug 26949] WebCore part of the Haiku WebKit port : [Attachment 32219] Patch to add Haiku-specific files for WebCore/platform/image-decoders/.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 7 00:27:56 PDT 2009


Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32219: Patch to add Haiku-specific files for
WebCore/platform/image-decoders/.
https://bugs.webkit.org/attachment.cgi?id=32219&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
This cast seems unecessary:
+    const void* bytes = (const void*)m_bytes.data();

STyle:
+int RGBA32Buffer::width() const {
+    return m_size.width();
+}
+
+int RGBA32Buffer::height() const {
+    return m_size.height();
+}


More information about the webkit-reviews mailing list