[webkit-reviews] review granted: [Bug 26949] WebCore part of the Haiku WebKit port : [Attachment 32220] Patch to add Haiku-specific files for WebCore/platform/text/.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 7 00:26:30 PDT 2009
Eric Seidel <eric at webkit.org> has granted Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949
Attachment 32220: Patch to add Haiku-specific files for WebCore/platform/text/.
https://bugs.webkit.org/attachment.cgi?id=32220&action=edit
------- Additional Comments from Eric Seidel <eric at webkit.org>
Does this copy the data?
string.SetTo(utf8().data());
If it doesn't then your WebKit will crash all the time as StringImpls get
released before the corresponding BStrings do...
r+ assuming this won't crash. :)
More information about the webkit-reviews
mailing list