[webkit-reviews] review requested: [Bug 26987] Add fast case for Math.floor(a / b) expressions : [Attachment 32297] getType() method added for all leaf Nodes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 6 06:08:45 PDT 2009


Zoltan Herczeg <zherczeg at inf.u-szeged.hu> has asked  for review:
Bug 26987: Add fast case for Math.floor(a / b) expressions
https://bugs.webkit.org/show_bug.cgi?id=26987

Attachment 32297: getType() method added for all leaf Nodes
https://bugs.webkit.org/attachment.cgi?id=32297&action=edit

------- Additional Comments from Zoltan Herczeg <zherczeg at inf.u-szeged.hu>
I split the patch into two parts for easier review.

Since my mthod detects Math.floor(a/b) expressions in AST level, I need some
kind of node type. I decided to use virtual methods for this task, because
emitByteCode has already virtual, so virtual method table has already generated
for all nodes.

Perhaps some virtual functions can be eliminated in ExpressionNode using these
types.


More information about the webkit-reviews mailing list