[webkit-reviews] review granted: [Bug 26982] Use soup's content sniffing : [Attachment 32279] Use soup's content sniffing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 6 04:47:33 PDT 2009


Jan Alonzo <jmalonzo at gmail.com> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 26982: Use soup's content sniffing
https://bugs.webkit.org/show_bug.cgi?id=26982

Attachment 32279: Use soup's content sniffing
https://bugs.webkit.org/attachment.cgi?id=32279&action=edit

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> -	       , m_reportedHeaders(false)

Please don't forget to remove m_reportedHeaders decl too.

> +static void contentSniffedCallback(SoupMessage* msg, const char*
sniffedType, GHashTable *params, gpointer data)
> +{
> +    if (sniffedType) {
> +	   const char* officialType =
soup_message_headers_get_one(msg->response_headers, "Content-Type");
> +
> +	   if (!officialType || strcmp(officialType, sniffedType))
> +	       soup_message_headers_set_content_type(msg->response_headers,
sniffedType, params);
> +    }

Ok. r=me.


More information about the webkit-reviews mailing list